[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    Re: evcalibrate
From:       Alan McCosh <amccosh () gmail ! com>
Date:       2010-01-27 21:55:20
Message-ID: c9d40de91001271355m4b1ea7a7l10f1d6d5436590cd () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


>
> Looking at the patches, they all modify evdev, but they seem to be more
>
of a "workaround" kind than real fixes:
> +    if (id[1]==0xeef && id[2]==0x1)
> +    {
> +       pEvdev->egalaxHack=TRUE;
> +       xf86Msg(X_INFO, "%s: Enabling egalax hack (Z/Rx)->(X/Y)\n",
> pInfo->name);
>
> or:
> +                       case 330: // button up/down
> +                       case 272:


> It seems like the real fixes should go into the kernel drivers, to
> follow a more standard interface. Have you reported the bugs, or
> contacted the maintainers of the respective drivers? It would be great
> to do so!
>

The eGalax axis-remapping is definitely a hack/workaround.  I'll report the
bugs and contact the maintainers asap.

The 3M patch is a userspace event filter and I *think* rightly belongs in
xf86-input-evdev.

[Attachment #5 (text/html)]

<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im">Looking at the \
patches, they all modify evdev, but they seem to be more</div></blockquote> \
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex;"> of a &quot;workaround&quot; kind than real fixes:<br>
+    if (id[1]==0xeef &amp;&amp; id[2]==0x1)<br>
+    {<br>
+       pEvdev-&gt;egalaxHack=TRUE;<br>
+       xf86Msg(X_INFO, &quot;%s: Enabling egalax hack (Z/Rx)-&gt;(X/Y)\n&quot;, \
pInfo-&gt;name);<br> <br>
or:<br>
+                       case 330: // button up/down<br>
+                       case 272:</blockquote><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> <br>
It seems like the real fixes should go into the kernel drivers, to<br>
follow a more standard interface. Have you reported the bugs, or<br>
contacted the maintainers of the respective drivers? It would be great<br>
to do so!<br></blockquote><div> </div><div>The eGalax axis-remapping is definitely a \
hack/workaround.  I&#39;ll report the bugs and contact the maintainers \
asap.</div><div><br></div><div>The 3M patch is a userspace event filter and I *think* \
rightly belongs in xf86-input-evdev.</div> </div>



_______________________________________________
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg

[prev in list] [next in list] [prev in thread] [next in thread]