[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    Re: xcompmgr -- Bugfix: missing determine_mode() in configure_win()
From:       Eeri Kask <Eeri.Kask () inf ! tu-dresden ! de>
Date:       2009-09-25 17:31:24
Message-ID: 4ABCFE6C.5010106 () inf ! tu-dresden ! de
[Download RAW message or body]

> it appears configure_win() lacks a call to determine_mode() so
> window mode is uninitialised in subsequent call to win_extents().

Attached is an alternative, probably a better solution to that above
problem: introduce the missing determine_mode() into add_win() as
this problem affects clients started _after_ starting xcompmgr, and
which therefore are not yet 'mapped', but will be 'configured' first.

Greetings,

    Eeri Kask


["xcompmgr.c.AddWinDetermineMode.diff" (text/plain)]

--- xcompmgr.c.AddWinDetermineMode.orig	2009-09-25 18:08:07.000000000 +0200
+++ xcompmgr.c	2009-09-25 18:07:34.000000000 +0200
@@ -1479,6 +1479,8 @@
     *p = new;
     if (new->a.map_state == IsViewable)
 	map_win (dpy, id, new->damage_sequence - 1, True);
+    else
+	determine_mode (dpy, new);
 }
 
 static void


_______________________________________________
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg

[prev in list] [next in list] [prev in thread] [next in thread]