[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    Re: [PATCH] Patch to not fork/exec xkbcomp on X Server initialization
From:       "Li, Yan" <yanli () infradead ! org>
Date:       2009-03-30 11:55:59
Message-ID: 20090330115559.GA31220 () thyme ! bj ! intel ! com
[Download RAW message or body]

On Fri, Mar 27, 2009 at 11:17:14AM +1000, Peter Hutterer wrote:
> I think /var/cache instead of /var/lib is the better place to put the files.
> http://www.pathname.com/fhs/pub/fhs-2.3.html#VARLIBVARIABLESTATEINFORMATION
> vs.
> http://www.pathname.com/fhs/pub/fhs-2.3.html#VARCACHEAPPLICATIONCACHEDATA

OK, got it.

> > In this patch there are also corrections to wrongly used TAB for
> > indention of codes related to this function. If you don't like it I
> > can move them to another standalone patch.
> 
> Yes, please always do things like that (if needed at all) in a separate patch.
> If you correct tab/space issues in the code you're modifying it doesn't
> matter much, but this patch is quite noisy.

OK, removed.

> > I understood the difficulty of merging functions like this into
> > mainstream. Or if we need to add an option to make this behaviour
> > optional, rather than enabled by default.  I'd like to follow on this
> > until people is happy with it.
> 
> It's looking good from a first pass, but I'd really like to see the patches
> split into one containing just the actual changes. I'm happy to test it then.

Thanks. I'm sending the v2 patch soon replying this mail.


-- 
Li, Yan
_______________________________________________
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg
[prev in list] [next in list] [prev in thread] [next in thread]