[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    Re: [RFC] xkb: processInputProc wrapping and FreezeThaw
From:       Daniel Stone <daniel () fooishbar ! org>
Date:       2008-03-28 8:21:12
Message-ID: 20080328082112.GA2738 () fooishbar ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Fri, Mar 28, 2008 at 12:55:40AM -0400, Thomas Jaeger wrote:
> If FreezeThaw is called inside a UNWRAP_PROCESS_INPUT_PROC /
> COND_WRAP_PROCESS_INPUT_PROC pair, the X server might be left in a
> broken state.  This problem was addressed in commit
> 50e80c39870adfdc84fdbc00dddf1362117ad443 [1], but the workaround doesn't
> cover all possible cases.  There is a bug that is fairly easy to
> reproduce [2,3] where the server will autorepeat a key forever if it is
> released under load and compiz is running.
> 
> The attached patch tries to offer a complete solution to the problem,
> implemented as follows.  The UNWRAP/COND_WRAP macros set both
> realInputProc and processInputProc, unless "regular" input processing is
> suspended currently suspended (this is the case if processInputProc !=
> realInputProc), in which case only realInputProc is updated.

Okay, this looks fine to me.  The reasoning's sound and wow, comments!
Novel.

I can't think of a case where we'd possibly want to smash the enqueue
proc, so yeah, looks good.  ajax, do you want to merge this to both
master and 1.5?

Cheers,
Daniel

["signature.asc" (application/pgp-signature)]

_______________________________________________
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg

[prev in list] [next in list] [prev in thread] [next in thread]