[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    Re: Proposal for X Server Plug-in Picker
From:       Eamon Walsh <ewalsh () tycho ! nsa ! gov>
Date:       2006-11-30 22:54:58
Message-ID: 1164927298.2794.245.camel () moss-huskies ! epoch ! ncsc ! mil
[Download RAW message or body]

On Fri, 2006-12-01 at 00:06 +0200, Daniel Stone wrote:
> On Thu, Nov 30, 2006 at 12:47:39PM -0800, Deron Johnson wrote:
> > #ifdef PICKER
> >        PICKER_WINDOWS_RESTRUCTURED(syncEvents.replayWin);
> > #endif /* PICKER */
> 

Can these macros be made inline functions instead via _X_INLINE?  Also, 
in the places where you replace an entire dix function, why not move
those functions to a separate source file instead, have two versions of
it, and use autotools to pick one or the other.


> (The security stuff is high up on my wishlist of ifdefs to axe.  Just
>  short-circuit the functions to always return success if we don't build
>  it in.  No point needlessly uglifying the code; if you're going to make
>  code changes, then you're going to make code changes, no matter how
>  many ifdefs you scatter.)

I dislike the ifdefs and screaming caps as well.  I will remove the
ifdef's around the XACE calls and define them away when XACE is not
built; I was just waiting for the release dust to settle.  

This could also be done for the DTRACE stuff that was recently dropped
on dix...


-- 
Eamon Walsh <ewalsh@tycho.nsa.gov>
National Security Agency


[prev in list] [next in list] [prev in thread] [next in thread]