[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    Re: [PATCH] Allow AIGLX drivers to enable extensions that they
From:       "=?UTF-8?Q?Kristian_H=C3=B8gsberg?=" <krh () bitplanet ! net>
Date:       2006-08-30 2:14:55
Message-ID: 59ad55d30608291914q3beb7604tc723818df28b2bf () mail ! gmail ! com
[Download RAW message or body]

On 8/29/06, Ian Romanick <idr@us.ibm.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> This patch adds missing support for AIGLX drivers to enable the GLX
> extensions that they support.  In addition, this fixes some bugs WRT to
> GLX extensions with AIGLX.  Right now GL_SGI_make_current_read is always
> enabled, but some of our drivers (e.g., radeon, r200, r300) do *not*
> support this extension.

The patch looks good to me, it makes AIGLX behave properly wrt
advertised extensions.  Only comment is that for now, GLX_EXT_tfp is
entirely implemented in glxdri.c and thus always available, so the 'N'
should be changed to 'Y' instead.  Even when we later on gain driver
support for this, we will still keep the generic implementation
around, so 'Y' makes sense now and later.

On a side note, I'd really like to get rid of all the unsued swap
barrier stub code.  Any objections?  We can add it back in a way that
sits better with the new structure of the GLX module if we need it.

Kristian

[prev in list] [next in list] [prev in thread] [next in thread]