[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    Re: [PATCH] Accelerated two directional blt support for EXA
From:       Adam Jackson <ajax () nwnk ! net>
Date:       2006-02-28 14:01:33
Message-ID: 200602280901.36717.ajax () nwnk ! net
[Download RAW message or body]


On Tuesday 28 February 2006 00:50, Jesse Barnes wrote:
> On Monday, February 27, 2006 8:02 am, Adam Jackson wrote:
> > Also, maybe split the lame code into a static function for
> > readability?  The fallback nearly doubles the size of exaCopyNtoN
> > which is otherwise quite readable.
>
> Ok, here's an updated version, how does it look?  (Btw, I've checked in
> the exaInitCard changes I mentioned earlier following Keith's
> suggestion of just making it a function in exa.h with the prototype in
> exa.h.)

PrepareCopy return value should be checked and FALSE thrown if it fails, which 
will catch the case of the card being exceptionally lame and not supporting 
the rop or the planemask.

- ajax

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]