[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    Re: render improvements
From:       Keith Packard <keithp () keithp ! com>
Date:       2005-06-15 19:52:53
Message-ID: 1118865173.7316.111.camel () evo ! keithp ! com
[Download RAW message or body]


On Wed, 2005-06-15 at 19:37 +0200, Zack Rusin wrote:

> This is an artifact of our emacs configurations. It's only a problem because 
> the freedesktop cvs script generates funky patches.

No, the freedesktop CVS script shows the entire patch, not
just the 'non-whitespace' changes.

>  We could remove it but a 
> lot more general and proper fix would be to simply add -b -B switches to the 
> script that generates the diff on the server.

No.  I want to see whitespace changes because these
may well mark errors in old or new code

	if (foo)
		bar;
-		bletch;
+	bletch;

is rather important to see.

Where whitespace makes the code ambiguous or possible wrong, a patch
that fixes that would be fine, but automatically modifying code in
invisible ways doesn't seem to me to have any value at all.

-keith


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]