[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    Re: CVS Update: xc (branch: trunk)
From:       Josh Triplett <josh.trip () verizon ! net>
Date:       2005-05-28 6:24:49
Message-ID: 42980EB1.7000407 () verizon ! net
[Download RAW message or body]


Matthieu Herrb wrote:
> Josh Triplett wrote:
>> CVSROOT:    /cvs/xorg
>> Module name:    xc
>> Changes by:    josh@gabe.freedesktop.org    05/05/27 10:44:08
>>
>> Log message:
>>   Reference X11/fonts header files using X11/fonts/ prefix.
>>
[...]
> 
> This breaks the monolitic tree build
> 
> cc -c -pipe -Wall -Wpointer-arith -Wstrict-prototypes  
> -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls
> -Wnested-externs -Wundef  -I../../../include/fonts -I../include 
> -I../../.. -I../../../exports/include   -DCSRG_BASED -DFUNCPROTO=15
> -DNARROWPROTO   -DBDFFORMAT -DPCFFORMAT -DSNFFORMAT   -O2
> -fno-strict-aliasing   bdfread.c -o unshared/bdfread.o
> In file included from bdfread.c:58:
> ../include/fntfilst.h:43:34: X11/fonts/fontstruct.h: No such file or
> directory
[...]

Thanks for catching this and adding the appropriate fix to the
monolithic tree.  I looked this commit over very carefully before
committing, and it certainly looked as though all the headers in
xc/includes/fonts/* would be available as <X11/fonts/*> in the
monolithic tree; I thought that BuildIncludes did that, and didn't
realize that each header needed to be explicitly exported.
xc/include/fonts/fontstruct.h should definitely be available as
<X11/fonts/fontstruct.h> during the build.

- Josh Triplett

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]