[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    Re: render improvements
From:       Owen Taylor <otaylor () redhat ! com>
Date:       2005-04-26 16:38:01
Message-ID: 1114533481.11262.10.camel () huygens
[Download RAW message or body]


On Mon, 2005-04-25 at 20:04 -0400, Zack Rusin wrote:
> On Friday 15 April 2005 20:14, Adam Jackson wrote:
> > This fails rendercheck (from /cvs/xapps) for a few transformations
> > and for the component alpha case.  I don't know whether that's a bug
> > in your code or in rendercheck but we should verify it.
> 
> Today Lars fixed rendercheck. The new implementation is passing both on 
> xserver and Xorg so I think we're ready to commit it :)
> Xserver patch is here:
> http://ktown.kde.org/~zrusin/xserver_new_render.diff
> Xorg patch at:
> http://ktown.kde.org/~zrusin/xorg_new_render.diff
> Owen, could you double checked that I didn't goofed when merging your 
> mmx changes?

Does xorg really compile with USE_MMX defined and your changes?
It looks like you merged all the fbpict.c changes from xserver
to xorg (good) but the xserver versions has a couple of new/renamed
MMX functions and the corresponding fbmmx.[ch] changes aren't merged.

All the changes to fbmmx.[ch] can be merged except for those related
to the difference in the sign of fbGetDrawable (changing '- xoff' to
'+ xoff' in various places).

Regards,
					Owen


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]