[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xdg
Subject:    Some Icon Theme Spec fixes
From:       Rodney Dawes <dobey () novell ! com>
Date:       2005-03-22 20:42:24
Message-ID: 1111524144.15940.22.camel () blackbox ! cam ! novell ! com
[Download RAW message or body]

This patch provides a few fixes to the text in the Icon Theme spec, as
well as a few enhancements.

The main enhancement here is specifying the standard themes directory,
that we already use for GTK+ and Metacity themes, as primary places to
look for icons, while deprecating the other "icons" directories. This
allows artists to easily group their themes all in the same tarballs.
I also have a patch to GTK+, and one to the Gnome Control Center to
make this work for Gnome. If I knew the QT/KDE code, I would have made
patches for those as well.

Another change is to reference "x-directory-normal" instead of
"mime_source_c" in the example to show the corelation between the
icon.{png,svg} and icon.icon files, in preparation for the upcoming
standard icon naming spec draft and proposal.

Can we get these changes in to the spec? Thanks.

-- dobey




["icon-theme-spec-fixes.patch" (icon-theme-spec-fixes.patch)]

Index: spec/icon-theme-spec.xml
==================================================================RCS file: \
/cvs/icon-theme/default-icon-theme/spec/icon-theme-spec.xml,v retrieving revision 1.3
diff -u -p -r1.3 icon-theme-spec.xml
--- spec/icon-theme-spec.xml	5 Feb 2004 18:34:59 -0000	1.3
+++ spec/icon-theme-spec.xml	22 Mar 2005 20:38:27 -0000
@@ -80,15 +80,18 @@
     <title>Directory Layout</title>
     <para>
     Icons and themes are looked for in a set of directories. By
-    default, apps should look in $HOME/.icons (for backwards compatibility),
-    in $XDG_DATA_DIRS/icons and in /usr/share/pixmaps (in that order).
-    Applications may further add
+    default, apps should look in $XDG_DATA_HOME/themes/$THEMENAME/icons,
+    $HOME/.themes/$THEMENAME/icons (for backwards compatibility),
+    $XDG_DATA_HOME/icons (for backwards compatibility)
+    $HOME/.icons (for backwards compatibility),
+    $XDG_DATA_DIRS/themes/$THEMENAME/icons,
+    $XDG_DATA_DIRS/icons (for backwards compatibility),
+    and /usr/share/pixmaps (in that order). Applications may further add
     their own icon directories to this list, and users may extend or
     change the list (in application/desktop specific ways).In each of
     these directories themes are stored as subdirectories. A theme can
     be spread across several base directories by having subdirectories of
-    the same name. This way users can extend and override system
-    themes.
+    the same name. This way users can extend and override system themes.
     </para>
     <para>
     In order to have a place for third party applications to install
@@ -130,8 +133,8 @@
     addition to this there may be an additional file with extra
     icon-data for each file. It should have the same basename as the
     image file, with the extension ".icon". e.g. if the icon file is
-    called "mime_source_c.png" the corresponding file would be named
-    "mime_source_c.icon".
+    called "x-directory-normal.png" the corresponding file would be named
+    "x-directory-normal.icon".
     </para>
   </sect1>

@@ -394,12 +397,12 @@
     </para>
     <para>
     The lookup is done first in the current theme, and then
-    recursively in each of the themes inherited the current theme, and
+    recursively in each of the current theme's parents, and
     finally in the default theme called "hicolor" (implementations may
     add more default themes before "hicolor", but "hicolor" must be
     last). As soon as there is an icon of any size that matches in a
-    theme the search is stopped. Even if there may be an icon with a
-    size closer to the correct one in an inherited theme we don't want
+    theme, the search is stopped. Even if there may be an icon with a
+    size closer to the correct one in an inherited theme, we don't want
     to use it. Doing so may generate an inconsistant change in an icon
     when you change icon sizes (e.g. zoom in).
     </para>
@@ -556,10 +559,10 @@ AttachPoints ,20|40,40|50,10|10,50</pr
     So, you're an application author, and want to install application icons
     so that they work in the KDE and Gnome menus. Minimally you should install
     a 48x48 icon in the hicolor theme. This means installing a PNG file in
-    $prefix/share/icons/hicolor/48x48/apps. Optionally you can install icons in \
                different
-    sizes. You might even want to install icons with a look that matches other
-    well known themes so your application will fit in with some specific desktop
-    environment.
+    $prefix/share/themes/hicolor/icons/48x48/apps. Optionally you can install
+    icons in different sizes. You might even want to install icons with a
+    look that matches other well known themes so your application will fit in
+    with some specific desktop environment.
     </para>
     <para>
     It is recommended that the icons installed in the hicolor theme look neutral,
@@ -628,7 +631,7 @@ AttachPoints ,20|40,40|50,10|10,50</pr
 	<itemizedlist>
 	  <listitem>
 	    <para>
-            Convertet to basedir spec.
+            Converted to basedir spec.
 	    </para>
 	  </listitem>
 	  <listitem>



[prev in list] [next in list] [prev in thread] [next in thread]