[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xcb
Subject:    Re: [Xcb] [PATCH] Increase unix socket send buffer to at least 64KB
From:       Mark Kettenis <mark.kettenis () xs4all ! nl>
Date:       2016-02-02 19:08:06
Message-ID: 201602021908.u12J8655005785 () glazunov ! sibelius ! xs4all ! nl
[Download RAW message or body]

> Date: Sun, 24 Jan 2016 10:48:41 +0100
> From: Matthieu Herrb <matthieu@herrb.eu>
>
> On Sat, Jan 23, 2016 at 05:29:32PM +0100, Mark Kettenis wrote:
> > Some systems (e.g. OpenBSD) have a rather small default socket send buffer
> > size of 4KB.  The result is that sending requests with a largish payload
> > requires serveral writev(2) system calls.  Make sure the socket send buff> er
> > is at least 64KB such that we're likely to succeed with a single system
> > call for most requests.  A similar change was made to the xtrans code
> > some time ago.
> > 
> > Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
>
> Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>

Looks like I don't have write permission to the libxcb repo.  Can
somebody push this for me, or give me write permission?

Thanks,

Mark

> > ---
> >  src/xcb_util.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/src/xcb_util.c b/src/xcb_util.c
> > index ba0f108..a3357ef 100644
> > --- a/src/xcb_util.c
> > +++ b/src/xcb_util.c
> > @@ -428,6 +428,8 @@ static int _xcb_open_unix(char *protocol, const char > *file)
> >  {
> >      int fd;
> >      struct sockaddr_un addr;
> > +    socklen_t len = sizeof(int);
> > +    int val;
> >  
> >      if (protocol && strcmp("unix",protocol))
> >          return -1;
> > @@ -440,6 +442,11 @@ static int _xcb_open_unix(char *protocol, const char>  *file)
> >      fd = _xcb_socket(AF_UNIX, SOCK_STREAM, 0);
> >      if(fd == -1)
> >          return -1;
> > +    if(getsockopt(fd, SOL_SOCKET, SO_SNDBUF, &val, &len) == 0 && val>  < 64 * 1024)
> > +    {
> > +        val = 64 * 1024;
> > +        setsockopt(fd, SOL_SOCKET, SO_SNDBUF, &val, sizeof(int));
> > +    }
> >      if(connect(fd, (struct sockaddr *) &addr, sizeof(addr)) == -1) {
> >          close(fd);
> >          return -1;
> > -- 
> > 2.7.0
> > 
> > _______________________________________________
> > Xcb mailing list
> > Xcb@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/xcb
>
> -- 
> Matthieu Herrb
_______________________________________________
Xcb mailing list
Xcb@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xcb
[prev in list] [next in list] [prev in thread] [next in thread]