[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xcb
Subject:    Re: [Xcb] [PATCH proto 2/2 RESEND] xml-xcb.txt: remove description of the "localfield" element
From:       Christian Linhart <chris () DemoRecorder ! com>
Date:       2015-05-30 10:25:39
Message-ID: 55699023.3080100 () DemoRecorder ! com
[Download RAW message or body]

Hi Ran,

Thank you for the updated patch and sorry for my delayed review.

Your patch removes an obsolete part from the documentation.
Thank  you for noticing that.

Therefore:
Reviewed-by: Christian Linhart <chris@demorecorder.com>

I will push this patch right now because there was more than enough time for other reviews.

Chris

On 03/18/15 11:27, Ran Benita wrote:
> It was removed in:
> http://cgit.freedesktop.org/xcb/proto/commit/?id=854d08c8242e8fbe7b5a000b75ec6845419806c4
>
> Signed-off-by: Ran Benita <ran234@gmail.com>
> Reviewed-by: Peter Harris <pharris@opentext.com>
> ---
>  doc/xml-xcb.txt | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/doc/xml-xcb.txt b/doc/xml-xcb.txt
> index 8d914a1..12c0881 100644
> --- a/doc/xml-xcb.txt
> +++ b/doc/xml-xcb.txt
> @@ -218,13 +218,6 @@ enum; the value is restricted to one of the constants named in the enum.
>    of the list in terms of other fields in the structure.  See the section
>    "Expressions" for details on the expression representation.
>  
> -<localfield type="identifier" name="identifier" />
> -
> -  This element represents a parameter in a request that is not sent over the
> -  wire.  The field can be referenced in the length expressions of lists or in
> -  an exprfield.  The type attribute declares the data type of the field, and
> -  the name attribute gives the name of the field.
> -
>  <exprfield type="identifier" name="identifier">expression</exprfield>
>  
>    This element represents a field in a request that is calculated rather than

_______________________________________________
Xcb mailing list
Xcb@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xcb
[prev in list] [next in list] [prev in thread] [next in thread]