[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xcb
Subject:    [Xcb] [PATCH libxcb 1/1] fix ABI/API compatibility problem in present
From:       Christian Linhart <chris () demorecorder ! com>
Date:       2015-05-25 12:14:38
Message-ID: 1432556078-61670-1-git-send-email-chris () demorecorder ! com
[Download RAW message or body]

for function xcb_present_redirect_notify_sizeof

removing the explicit length of the list that was added since the
last release with the following changeset:
http://cgit.freedesktop.org/xcb/proto/commit/?id=c9b1523b23af52087a6354730f86b8d19fa3c7c0

Removing the explicit length again is OK because
implicit length is allowed when a list is the last
field of a request or event.

The compile problem that the prior change has tried to fix,
has been fixed in another way. Therefore removing the explicit length
is safe now.

Signed-off-by: Christian Linhart <chris@demorecorder.com>
---
 src/present.xml | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/present.xml b/src/present.xml
index 95fee01..513388c 100644
--- a/src/present.xml
+++ b/src/present.xml
@@ -195,19 +195,11 @@ <event name="RedirectNotify" number="3" xge="true">
     <field type="FENCE" name="wait_fence" />
     <field type="FENCE" name="idle_fence" />
     <field type="CARD32" name="options" />
     <pad bytes="4"/>
     <field type="CARD64" name="target_msc" />
     <field type="CARD64" name="divisor" />
     <field type="CARD64" name="remainder" />
-    <list type="Notify" name="notifies">
-        <op op="/">
-            <op op="-">
-                <fieldref>length</fieldref>
-                <value>18</value>
-            </op>
-            <value>2</value>
-        </op>
-    </list>
+    <list type="Notify" name="notifies" />
   </event>
 
 </xcb>
-- 
2.0.1

_______________________________________________
Xcb mailing list
Xcb@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xcb
[prev in list] [next in list] [prev in thread] [next in thread]