[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xcb
Subject:    Re: [Xcb] [PATCH proto 1/1] Moved BOOL32 definition form glx to xproto
From:       Christian Linhart <chris () DemoRecorder ! com>
Date:       2015-02-22 7:54:37
Message-ID: 54E98B3D.5050009 () DemoRecorder ! com
[Download RAW message or body]

Hi Jaya,

I have checked the changes in the generated code which this patch generates.
It introduces changes that destroy compatibility in the generated C-code.
So we cannot apply this patch. ( The blame is on me because I have suggested this patch ).

On the other hand, the BOOL32 from glx does
not cause a name-clash with the new BOOL32 from xproto
because the type is namespaced with "glx" in its name in the generated C-code of libxcb:
    typedef uint32_t xcb_glx_bool32_t;

So we don't need to do anything with the BOOL32 anyways.

Therefore I'll not merge this patch to upstream.
( and my prior "Reviewed-by:" is void therefore )

Sorry for not catching this earlier.

Regards,

Chris

On 12/25/14 13:40, Christian Linhart wrote:
> Hi Jaya,
>
> Thank you for this patch.
>
> Your patch is fine under the condition that it is applied together
> with your valaueparam->switch patch for xproto. 
> (otherwise, BOOL32 will be missing altogether)
>
> Therefore:
> Reviewed-by: Christian Linhart <chris@demorecorder.com>
>
> Chris
>
>
> On 12/23/14 18:34, Jaya Tiwari wrote:
>> Moved the BOOL32 casting from glx to xproto because of common usage of
>> BOOL32 in other extensions
>>
>> Signed-off-by: Jaya Tiwari <tiwari.jaya18@gmail.com>
>> ---
>>  src/glx.xml | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/src/glx.xml b/src/glx.xml
>> index 2a36daa..025b878 100644
>> --- a/src/glx.xml
>> +++ b/src/glx.xml
>> @@ -64,7 +64,6 @@
>>
>>      <typedef oldname="float" newname="FLOAT32" />
>>      <typedef oldname="double" newname="FLOAT64" />
>> -        <typedef oldname="CARD32" newname="BOOL32" />
>>          <typedef oldname="CARD32" newname="CONTEXT_TAG" />
>>
>>      <!-- Errors -->
>>
> _______________________________________________
> Xcb mailing list
> Xcb@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb

_______________________________________________
Xcb mailing list
Xcb@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xcb
[prev in list] [next in list] [prev in thread] [next in thread]