'[Xcb] [Bug 78140] The tutorial should have a section on error handling'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xcb
Subject:    [Xcb] [Bug 78140] The tutorial should have a section on error handling
From:       bugzilla-daemon () freedesktop ! org
Date:       2014-05-02 2:08:02
Message-ID: bug-78140-13485-DglYKPiHNk () http ! bugs ! freedesktop ! org/
[Download RAW message or body]

--1398996482.A3b0c8b0.31690
Date: Fri, 2 May 2014 02:08:02 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"

https://bugs.freedesktop.org/show_bug.cgi?id=78140

--- Comment #4 from Steven Stewart-Gallus <sstewartgallus00@mylangara.bc.ca> ---
I find it unfortunate that xcb_disconnect does not return an error code.

First of all, the close and EINTR problem is easily solvable. Simply, block all
signals while closing a file and then the EINTR error can never happen.

Second of all, an obvious thing to do if close fails in a process is to exit
the process and disable that part of the system but keep the rest of the system
running (that way someone can run a debug console later on and diagnose and fix
the problem or recover data if the system is truely broken). Simply going on
instead is wrong because that might result in corrupting user data. I'd even
rather have the function abort on errors then simply ignore them.

Thirdly, pthread_mutex_destroy and pthread_cond_destroy should not fail with 
errors on proper use of their functionality so they are irrelevant.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

--1398996482.A3b0c8b0.31690
Date: Fri, 2 May 2014 02:08:02 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"

<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - The tutorial should have a section on error handling"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=78140#c4">Comment # 4</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - The tutorial should have a section on error handling"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=78140">bug 78140</a>
              from <span class="vcard"><a class="email" \
href="mailto:sstewartgallus00&#64;mylangara.bc.ca" title="Steven Stewart-Gallus \
&lt;sstewartgallus00&#64;mylangara.bc.ca&gt;"> <span class="fn">Steven \
Stewart-Gallus</span></a> </span></b>
        <pre>I find it unfortunate that xcb_disconnect does not return an error code.

First of all, the close and EINTR problem is easily solvable. Simply, block all
signals while closing a file and then the EINTR error can never happen.

Second of all, an obvious thing to do if close fails in a process is to exit
the process and disable that part of the system but keep the rest of the system
running (that way someone can run a debug console later on and diagnose and fix
the problem or recover data if the system is truely broken). Simply going on
instead is wrong because that might result in corrupting user data. I'd even
rather have the function abort on errors then simply ignore them.

Thirdly, pthread_mutex_destroy and pthread_cond_destroy should not fail with 
errors on proper use of their functionality so they are irrelevant.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the QA Contact for the bug.</li>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>

--1398996482.A3b0c8b0.31690--

_______________________________________________
Xcb mailing list
Xcb@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xcb

[prev in list] [next in list] [prev in thread] [next in thread] 