[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xcb
Subject:    Re: [Xcb] [PATCH proto 2/2] xkb: Fix key type map entry field order
From:       Peter Harris <pharris () opentext ! com>
Date:       2013-07-23 13:40:09
Message-ID: 51EE87B9.5060201 () opentext ! com
[Download RAW message or body]

On 2013-07-23 06:33, Ran Benita wrote:
> In fact, unlike the deleted comment says, both Xlib and the server use
> the order as specified in the protocol spec:
> http://www.x.org/releases/current/doc/kbproto/xkbproto.html#appD::Requests
> (Search for KB_KTMAPENTRY).
> 
> Also see struct xkbKTMapEntryWireDesc in
> /usr/include/X11/extensions/XKBproto.h

Added in
http://cgit.freedesktop.org/xcb/proto/commit/?id=76ca2c0b1527541be59c344118c538ba055ad9d8

I'm guessing the original author was confused by XkbKTMapEntryRec in
/usr/include/X11/extensions/XKBstr.h

Once again, Xlib's propensity for API structures that don't match the
wire structures causes confusion.

Reviewed-by: Peter Harris <pharris@opentext.com>

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris@opentext.com            Toll Free: 1 877 359 4866
_______________________________________________
Xcb mailing list
Xcb@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xcb
[prev in list] [next in list] [prev in thread] [next in thread]