[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xcb
Subject:    Re: [Xcb] [PATCH] xkb: Fix opcode for Bell and GetState requests
From:       Ian Osgood <iano () quirkster ! com>
Date:       2010-03-29 19:42:38
Message-ID: F7BD07A4-8D5F-4810-82DB-53E827426F5C () quirkster ! com
[Download RAW message or body]

Yep, checked it against xorg/proto/kbproto/XKB.h  (I wonder why that hole is there?)

Reviewed-by: Ian Osgood <iano@quirkster.com>

On Mar 29, 2010, at 12:32 PM, Peter Harris wrote:

> Signed-off-by: Peter Harris <pharris@opentext.com>
> ---
> 
> There is a hole in the opcode space for xkb, but it was in the wrong place
> due to a typo.  Bump up Bell and GetState, to match
> http://cgit.freedesktop.org/xorg/proto/kbproto/tree/XKB.h
> 
> src/xkb.xml |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/xkb.xml b/src/xkb.xml
> index fb97ba4..33d3ea3 100644
> --- a/src/xkb.xml
> +++ b/src/xkb.xml
> @@ -1127,7 +1127,7 @@ authorization from the authors.
> 		</switch>
> 	</request>
> 
> -	<request name="Bell" opcode="2">
> +	<request name="Bell" opcode="3">
> 		<field name="deviceSpec" type="DeviceSpec" />
> 		<field name="bellClass" type="BellClassSpec" />
> 		<field name="bellID" type="IDSpec" />
> @@ -1142,7 +1142,7 @@ authorization from the authors.
> 		<field name="window" type="WINDOW" />
> 	</request>
> 
> -	<request name="GetState" opcode="3">
> +	<request name="GetState" opcode="4">
> 		<field name="deviceSpec" type="DeviceSpec" />
> 		<pad bytes="2" />
> 		<reply>
> -- 
> 1.7.0.3
> 
> _______________________________________________
> Xcb mailing list
> Xcb@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb


_______________________________________________
Xcb mailing list
Xcb@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xcb
[prev in list] [next in list] [prev in thread] [next in thread]