[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xcb
Subject:    Re: [Xcb] [PATCH 2/2] Remove constant definition
From:       Eamon Walsh <ewalsh.mailinglists () gmail ! com>
Date:       2010-01-26 4:25:12
Message-ID: 4B5E6EA8.5050800 () gmail ! com
[Download RAW message or body]

Julien Danjou wrote:
> At 1264380897 time_t, Eamon Walsh wrote:
>   
>>> -    /* Basic constants */
>>> -    PyModule_AddIntConstant(m, "X_PROTOCOL", X_PROTOCOL);
>>> -    PyModule_AddIntConstant(m, "X_PROTOCOL_REVISION", X_PROTOCOL_REVISION);
>>> -    PyModule_AddIntConstant(m, "X_TCP_PORT", X_TCP_PORT);
>>> -    PyModule_AddIntConstant(m, "NONE", XCB_NONE);
>>> -    PyModule_AddIntConstant(m, "CopyFromParent", XCB_COPY_FROM_PARENT);
>>> -    PyModule_AddIntConstant(m, "CurrentTime", XCB_CURRENT_TIME);
>>> -    PyModule_AddIntConstant(m, "NoSymbol", XCB_NO_SYMBOL);
>>> -
>>>       
>> The constants above are defined in xcb.h, not xproto.xml, making them
>> hard-coded parts of libxcb.  So I think they need to remain hard-coded
>> in xpyb as well unless there is something I'm missing.  The xproto.xml
>> file contains an alternate definition of XCB_CURRENT_TIME (in the "Time"
>> enum), but none of the other constants above are defined there currently.
>>
>> The atom constants definitely should go and I will push that part of the
>> patch.
>>     
>
> You're right, I totally missed that lines.
> Is XCB_COPY_FROM_PARENT worh it too? It seems at least defined once (in
> class WindowlClass, but I'm not sure it's not used in some other function.
>
>   

CopyFromParent can be used for other fields of the CreateWindow request
besides the class.  It works as a visual and (effectively) a depth.

--Eamon W.

_______________________________________________
Xcb mailing list
Xcb@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xcb
[prev in list] [next in list] [prev in thread] [next in thread]