[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-poppler
Subject:    [poppler] poppler/StructElement.cc
From:       carlosgc () kemper ! freedesktop ! org (Carlos Garcia Campos)
Date:       2014-02-23 17:18:53
Message-ID: 20140223171853.845E27623C () kemper ! freedesktop ! org
[Download RAW message or body]

 poppler/StructElement.cc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b2394eee5384edf4128d598030989e66d64714ef
Author: Adrian Perez de Castro <aperez@igalia.com>
Date:   Mon Feb 10 20:29:35 2014 +0200

    Tagged-PDF: Fix parsing of attached element attributes
    
    The wrong object was used as attribute dictionary, which caused
    a segmentation fault when parsing PDF files in which the structure
    elements included attributes attached to them. This patch fixes the
    issue.
    
    Thanks to Joanmarie Diggs <jdiggs@igalia.com> for helping in
    debugging the problem.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=74805

diff --git a/poppler/StructElement.cc b/poppler/StructElement.cc
index c3724b8..ba859e9 100644
--- a/poppler/StructElement.cc
+++ b/poppler/StructElement.cc
@@ -1158,7 +1158,7 @@ void StructElement::parse(Dict *element)
     for (int i = 0; i < obj.arrayGetLength(); i++) {
       if (obj.arrayGet(i, &iobj)->isDict()) {
         attrIndex = getNumAttributes();
-        parseAttributes(obj.getDict());
+        parseAttributes(iobj.getDict());
       } else if (iobj.isInt()) {
         const int revision = iobj.getInt();
         // Set revision numbers for the elements previously created.
_______________________________________________
poppler mailing list
poppler@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/poppler
[prev in list] [next in list] [prev in thread] [next in thread]