[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-poppler
Subject:    Re: [poppler] [PATCH] Annotation removal improvements
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2012-05-24 16:24:02
Message-ID: 1987584.ac9hSsGPTz () xps
[Download RAW message or body]

El Dijous, 24 de maig de 2012, a les 11:50:37, Carlos Garcia Campos va =

escriure:
> Excerpts from Albert Astals Cid's message of mi=E9 may 23 20:01:08 +0200 =
2012:
> > El Dimarts, 22 de maig de 2012, a les 00:44:26, Fabio D'Urso va escriur=
e:
> > > On Sunday, May 20, 2012 07:04:45 PM Fabio D'Urso wrote:
> > > > On Sunday, May 20, 2012 12:27:52 PM Carlos Garcia Campos wrote:
> > > > > Why doesn't Page::removeAnnot() also remove the appearances? I've
> > > > > noticed that the qt4 implementation removes the popup and
> > > > > appearances
> > > > > manually. [...]
> > > > > What happens with all other objects referenced by annotations? I
> > > > > guess
> > > > > they are all left in the document, should we remove them too? like
> > > > > the
> > > > > appearances? [...]
> > > > > Maybe we could add a Annot::removeAnnotFromPage (or something like
> > > > > that) so that every annotation can implement it to remove the
> > > > > objects
> > > > > it references and not referenced by others.
> > > =

> > > The attached patch defines a virtual Annot::removeReferencedObjects
> > > method
> > > that each annotation type can reimplement. The base implementation ta=
kes
> > > care of removing the appearance stream. The AnnotMarkup implementation
> > > takes care of removing the popup too.
> > > =

> > > > I have some doubts about setting /P if the annotation has no /P or a
> > > > wrong
> > > > value, because that would mean that annotations are automatically
> > > > modified
> > > > as soon as the document is loaded.
> > > =

> > > This patch implements the following behavior:
> > >  - When parsing existing annotations, /P is ignored and the in-memory
> > >  =

> > >    page field is always set to the page which the annotation was read
> > >    from (without setting or changing the actual /P value).
> > >  =

> > >  - When adding a new annotation to a given page, /P is set accordingl=
y.
> > =

> > Carlos, does this work for you?
> =

> Yes.
> =

> > We'd be commiting this to master only right? No sense in commiting to 0=
.20
> > branch.
> =

> Yes, master only, do you want me to push it?

Please :-)

Albert

> =

> > Albert
> > =

> > > Fabio
_______________________________________________
poppler mailing list
poppler@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/poppler
[prev in list] [next in list] [prev in thread] [next in thread]