[prev in list] [next in list] [prev in thread] [next in thread]
List: freedesktop-poppler
Subject: Re: [poppler] Small bug in SplashBitmap.cc for poppler-0.20.0
From: Albert Astals Cid <aacid () kde ! org>
Date: 2012-05-17 17:56:24
Message-ID: 1944592.IuB323GFkH () xps
[Download RAW message or body]
El Dijous, 17 de maig de 2012, a les 09:53:31, Thomas Freitag va escriure:
> Hi,
>
> I got the attached hint from Anthony, and I agreed, so I created the
> attached one line patch.
> Please insert the copyright notice of Anthony, I don't want to adorn
> myself with borrowed plumes :-)
Commited, in the future Anthony I'd appreciate if you mailed the list directly
since there's really nothing that needs to be dealt in a 1:1 basis in that
patch :-)
Cheers,
Albert
>
> Cheers,
> Thomas
>
> <http://www.dict.cc/englisch-deutsch/plumes.html>On 16.05.2012 06:48,
>
> Anthony Wesley wrote:
> > Hi Thomas, hope you don't mind me emailing you direct about this,
> > there is a simple coding error in SplashBitmap.cc, in the function
> >
> > SplashError SplashBitmap::writeImgFile(ImgWriter *writer, FILE *f, int
> > hDPI, int vDPI)
> >
> > on line 522 (close to the end of the file) the test for error
> > condition on closing the writer is the wrong way around. The code
> >
> > should say:
> > if (! writer->close()) {
> >
> > return splashErrGeneric;
> >
> > }
> >
> > as the code is currently written this function always returns
> > SplashErrorGeneric.
> >
> > regards, Anthony
_______________________________________________
poppler mailing list
poppler@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/poppler
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic