[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-poppler
Subject:    Re: [poppler] utils/Makefile.am should copy libcms-related flags for pdftocairo?
From:       Adrian Johnson <ajohnson () redneon ! com>
Date:       2012-01-30 10:34:09
Message-ID: 4F266F51.4070203 () redneon ! com
[Download RAW message or body]

On 12/01/12 04:23, mpsuzuki@hiroshima-u.ac.jp wrote:
> Hi,
> 
> Current cmake file (utils/CMakeLists.txt) adds libcms
> to library list to build pdftocairo, like,
> 
>   add_executable(pdftocairo ${pdftocairo_SOURCES})
>   target_link_libraries(pdftocairo ${CAIRO_LIBRARIES} ${FREETYPE_LIBRARIES} ${common_libs})
>   if(LCMS_FOUND)
>     target_link_libraries(pdftocairo ${LCMS_LIBRARIES})
>   endif(LCMS_FOUND)
> 
> But utils/Makefile.am does not do such. If it's not my
> misunderstanding, please consider to add LCMS_{CFLAGS,LIBS}
> to PDFTOCAIRO_{CFLAGS,LIBS} when USE_CMS is defined.
> Patch is following.

Pushed to master and 0.18. Thanks for the patch.

> 
> Regards,
> mpsuzuki
> 
> diff --git a/utils/Makefile.am b/utils/Makefile.am
> index 951abdb..762598c 100644
> --- a/utils/Makefile.am
> +++ b/utils/Makefile.am
> @@ -30,6 +30,11 @@ pdftocairo_SOURCES =				\
>  	pdftocairo.cc				\
>  	$(common)
>  
> +if USE_CMS
> +PDFTOCAIRO_CFLAGS += $(LCMS_CFLAGS)
> +PDFTOCAIRO_LIBS += $(LCMS_LIBS)
> +endif
> +
>  pdftocairo_LDADD =				\
>  	$(top_builddir)/poppler/libpoppler-cairo.la \
>  	$(LDADD) $(PDFTOCAIRO_LIBS)
> _______________________________________________
> poppler mailing list
> poppler@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler

_______________________________________________
poppler mailing list
poppler@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/poppler
[prev in list] [next in list] [prev in thread] [next in thread]