[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-poppler
Subject:    Re: [poppler] [PATCH] [CMake] Preserve compile flags
From:       Maciej Mrozowski <reavertm () gmail ! com>
Date:       2010-05-17 21:36:13
Message-ID: 201005172336.14083.reavertm () gmail ! com
[Download RAW message or body]

On Tuesday 13 of April 2010 00:33:09 Albert Astals Cid wrote:

> Spoke about it on IRC, the patch is rejected since it changes the default
> warning flags passed to the compiler. And that is not in your changelog,
> please make your changelog say what your patch does.

Better patch attached.

cheers

-- 
regards
MM

["0001-CMake-Do-not-force-O2-preserve-compiler-flags-instea.patch" (text/x-patch)]

From 86104b2d192db72d7233163a7b45cf3194fbc95d Mon Sep 17 00:00:00 2001
From: Maciej Mrozowski <reavertm@gmail.com>
Date: Mon, 17 May 2010 23:31:09 +0200
Subject: [PATCH] [CMake] Do not force -O2, preserve compiler flags instead.

---
 cmake/modules/PopplerMacros.cmake |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cmake/modules/PopplerMacros.cmake b/cmake/modules/PopplerMacros.cmake
index e6b1efc..1f38a8d 100644
--- a/cmake/modules/PopplerMacros.cmake
+++ b/cmake/modules/PopplerMacros.cmake
@@ -102,9 +102,9 @@ if(CMAKE_COMPILER_IS_GNUCXX)
   # set the default compile warnings
   set(DEFAULT_COMPILE_WARNINGS_NO)
   set(DEFAULT_COMPILE_WARNINGS_YES "-Wall -Wno-write-strings")
-  set(DEFAULT_COMPILE_WARNINGS_KDE "-Wno-long-long -Wundef -D_XOPEN_SOURCE=600 \
-D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith \
-Wwrite-strings -O2 -Wformat-security -Wmissing-format-attribute -fno-exceptions \
-fno-check-new -fno-common") +  set(DEFAULT_COMPILE_WARNINGS_KDE "-Wno-long-long \
-Wundef -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts \
-Wall -W -Wpointer-arith -Wwrite-strings -Wformat-security -Wmissing-format-attribute \
-fno-exceptions -fno-check-new -fno-common")  
-  set(CMAKE_CXX_FLAGS                "-Wnon-virtual-dtor -Woverloaded-virtual")
+  set(CMAKE_CXX_FLAGS                "${CMAKE_CXX_FLAGS} -Wnon-virtual-dtor \
-Woverloaded-virtual")  set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g")
   set(CMAKE_CXX_FLAGS_RELEASE        "-O2 -DNDEBUG")
   set(CMAKE_CXX_FLAGS_DEBUG          "-g -O2 -fno-reorder-blocks -fno-schedule-insns \
                -fno-inline")
-- 
1.6.4.4



_______________________________________________
poppler mailing list
poppler@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/poppler


[prev in list] [next in list] [prev in thread] [next in thread]