2008/9/9 Victor Lowther : > On Tue, 2008-09-09 at 11:24 +0200, Tim Dijkstra wrote: >> Victor Lowther schreef: >> >> > I also trimmed s2ram from uswsusp -- we just fall back to kernel suspend >> > instead. This way, we only have to handle video quirks in one place, and >> > we control that place. >> >> So you are basically removing uswsusp support? That would be very >> unfortunate, than we will have to add our own patches again... > > Just s2ram. Handling quirks in s2ram and in 99video was just annoying, > but with the recent "interesting" behaviour of the nvidia g80/g90 chips > and their habit of only coming back from suspend if you posted from a > saved copy of the BIOS, s2ram was causing resume failures that 99video > handles correctly, so the old "disable 99video in favor of handling the > quirks in uswsusp" bahaviour missed this case when running with s2ram. > > While I suppose I could set up some sort of framework where certian > quirks are handled by s2ram and certian others are handled by 99video, > that seems like a recipie for disaster. > > s2disk and s2both are still supported by this patch series, and now we > force s2both to run quirkless. I could have s2ram do the same thing, > but since all it ends up doing the same as what we already do, it is > just as easy to fall back to the kernel method. Hi Victor et al, could we please split up the patch. Imo the autodetection idea is a good one, and I already implemented something like this for the Debian package. If we can get that upstream, even better ;-) Regarding, dropping support for s2ram, you already noticed there is too much controversy atm, so I'd leave it as is for now. This needs further discussion. In the end, I would welcome if we come to a solution which is acceptable for all distros and avoids the duplicated effort. I don't think it's a good idea to enforce such a decision upon everyone. We should first gather all pros and cons of the different approaches and try to reach a consensus. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? _______________________________________________ Pm-utils mailing list Pm-utils@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pm-utils