[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-pm-utils
Subject:    Re: [Pm-utils] [PATCH] parse video quirks in uswsusp sleep module
From:       Victor Lowther <victor.lowther () gmail ! com>
Date:       2008-03-17 0:40:25
Message-ID: 1205714425.13959.79.camel () sentry-no ! fnordovax ! org
[Download RAW message or body]

On Mon, 2008-03-17 at 01:13 +0100, Michael Biebl wrote:
> 2008/3/17, Victor Lowther <victor.lowther@gmail.com>:
> >
> > After a bit more review, your patch was not honoring QUIRK_NONE.  I
> >  readded support for it and pushed changes upstream.
> 
> Good point. You should have added it after
> [ $ACPI_SLEEP -ne 0 ] && OPTS="$OPTS --acpi_sleep $ACPI_SLEEP"
> though, to make absolutely sure, that OPTS is zero.

Not really. :)  The behaviour that 99video uses is to set the acpi_sleep
flag based on quirks no matter the state of QUIRK_NONE.  This patch
brings the uswsusp code in line with that logic.

Whether this is correct behaviour is another question, but the logic
99video uses has been that way for a long time and I don't want to mess
with it without good cause.

> >
> >  You may also want to prefix the environment variables you introduce in
> >  uswsusp with USWSUSP_ to prevent future namespace collisions.
> 
> If that problem arises, we can still add the prefix.

Hmmm... I would rather add it to help ensure that the problem never will
arise.

> Cheers,
> Michael
> 
-- 
Victor Lowther
Ubuntu Certified Professional

_______________________________________________
Pm-utils mailing list
Pm-utils@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pm-utils
[prev in list] [next in list] [prev in thread] [next in thread]