[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-pm-utils
Subject:    Re: [Pm-utils] [PATCH] parse video quirks in uswsusp sleep module
From:       Victor Lowther <victor.lowther () gmail ! com>
Date:       2008-03-16 22:05:02
Message-ID: 1205705102.13959.24.camel () sentry-no ! fnordovax ! org
[Download RAW message or body]

On Sun, 2008-03-16 at 18:50 +0100, Michael Biebl wrote:
> Hi,
> 
> attached is the patch, which parses the video quirks in the uswsusp
> sleep module and passes this options to s2ram/s2both.

In the get_quirks code, ACPI_SLEEP should be initailized to 0, not "".
Shell arithmetic may break otherwise, depending on your shell.

Otherwise, the patch looks fine.  

> The only open question is, if quirk-dpms*, quirk-reset-brightness and
> quirk-vga-mode3 should be shown in sleep_method_help or removed from
> get_quirks/sleep_method_help.
> 
> s2ram has no command line parameters for those options.
> 
> What do you think: Drop those parameters or leave them as is, as no-ops?

I would leave them as no-ops.  Less ambiguity that way.

> I also added the --quirk-save-pci option, even if that is not provided
> by hal yet.
> 
> 
> 
> I was also wondering, why reset_brighness in 99video isn't using
> vbetool's (get,set)brightness method.
> 
> Cheers,
> Michael
> 
> _______________________________________________
> Pm-utils mailing list
> Pm-utils@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/pm-utils
-- 
Victor Lowther
Ubuntu Certified Professional

_______________________________________________
Pm-utils mailing list
Pm-utils@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pm-utils
[prev in list] [next in list] [prev in thread] [next in thread]