[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-libburn
Subject:    Re: [Libburn] Looking at the libburn code
From:       Philip Martin <philip () codematters ! co ! uk>
Date:       2006-02-15 23:37:54
Message-ID: 87k6bwp50t.fsf () debian2 ! lan
[Download RAW message or body]

Derek Foreman <manmower@signalmarketing.com> writes:

> On Wed, 15 Feb 2006, Philip Martin wrote:
>>
>> - The pthread_mutex_xxx functions all have return values but these are
>>  ignored by the libburn code.  These functions are unlikely to fail,
>>  but assuming they won't fail is a bit of a gamble.
>
> I think pthread_mutex_lock/unlock will only fail if used incorrectly,
> therefor their returns are only interesting for assert()ions

I'd agree that it's acceptable for libburn to use asserts here.
However it's not true that pthread_mutex_lock failures need always
terminate an application.  "Robust mutexes" are already provided by
Solaris, and will probably come to Linux in the future, and they are
designed to allow an application to recover under certain
circumstances.

-- 
Philip Martin

[prev in list] [next in list] [prev in thread] [next in thread]