[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-intel-gfx
Subject:    Re: [Intel-gfx] [PATCH] drm/i915: Flush ggtt writes through the old fenced vma before changing fence
From:       "Lahtinen, Joonas" <joonas.lahtinen () intel ! com>
Date:       2018-01-31 10:46:47
Message-ID: 1517395605.8863.18.camel () intel ! com
[Download RAW message or body]

On Tue, 2018-01-30 at 16:44 +0000, Chris Wilson wrote:
> This is a precautionary measure as I have no evidence to suggest we've
> hit a bug here (I was hoping this might explain gdg's odd behaviour, but
> alas), but given that we have a function to flush the ggtt writes it
> seems prudent to use it prior to changing the fence register. Due to the
> intrinsic nature of the GTT often operating as an independent mmio path,
> we should not just rely on the write to the fence acting as a full flush
> for GTT writes.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic