[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-igt-dev
Subject:    Re: [igt-dev] [PATCH i-g-t 5/7] lib/igt_psr: modified psr_get_mode for pr compatability
From:       "Hogander, Jouni" <jouni.hogander () intel ! com>
Date:       2023-10-31 12:06:38
Message-ID: 761972b1a6acd4f2d79a5bdb501e3d2bcdb8a4dc.camel () intel ! com
[Download RAW message or body]

On Tue, 2023-10-31 at 13:39 +0530, Kunal Joshi wrote:
> Modified psr_get_mode for PR_MODE
> 
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Cc: Animesh Manna <animesh.manna@intel.com>
> Cc: Arun R Murthy <arun.r.murthy@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
>  lib/igt_psr.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index c2b2a4148..bddf80d6a 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -382,7 +382,9 @@ enum psr_mode psr_get_mode(int debugfs_fd)
>                 return PSR_DISABLED;
>         }
>  
> -       if (strstr(buf, "PSR2 selective fetch: enabled"))
> +       if (strstr(buf, "Panel Replay Enabled"))
> +               return PR_MODE;
> +       else if (strstr(buf, "PSR2 selective fetch: enabled"))
>                 return PSR_MODE_2_SEL_FETCH;
>         else if (strstr(buf, "PSR2 enabled"))
>                 return PSR_MODE_2;

You are missing Panel Replay Selective update. I would assume format
like this:
for PR Selective update:

Sink support: Panel Replay Selective update
PSR mode: Panel Replay Selective update enabled
Source PSR ctl: enabled [0xc2004a99]
Source PSR status: DEEP_SLEEP [0x80000100]
Busy frontbuffer bits: 0x00000000
Performance counter: 0
Frame:	PSR2 SU blocks:
0	0
1	0
2	0
3	0
4	0
5	0
6	0
7	0
PSR2 selective fetch: enabled

and PR:

Sink support: Panel Replay
PSR mode: Panel Replay enabled
PSR sink not reliable: no

BR,

Jouni Högander

[prev in list] [next in list] [prev in thread] [next in thread]