[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-igt-dev
Subject:    Re: [igt-dev] [PATCH v2] core_getversion: Test for desired device
From:       Daniel Stone <daniel () fooishbar ! org>
Date:       2023-09-26 16:42:26
Message-ID: CAPj87rOT3wuVpb3t2Ax_YvAMnmtL_xfzGKrdvzBar_QyHqyexw () mail ! gmail ! com
[Download RAW message or body]

On Mon, 25 Sept 2023 at 09:22, Rob Clark <robdclark@gmail.com> wrote:
> +       const char *name = getenv("IGT_REQUIRED_DRIVER");
>
> -       fd = drm_open_driver(DRIVER_ANY);
> +       fd = __drm_open_driver(DRIVER_ANY);

Shouldn't this try to open the actual driver name? Otherwise we could
false-fail a test because our 'any driver' picked the wrong device
when multiple of them are present.
[prev in list] [next in list] [prev in thread] [next in thread]