[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-igt-dev
Subject:    Re: [igt-dev] [i-g-t, V2] lib/i915: Use FIXED mapping only for discrete memory
From:       "Dixit, Ashutosh" <ashutosh.dixit () intel ! com>
Date:       2021-08-30 17:40:16
Message-ID: 8735qqx24f.wl-ashutosh.dixit () intel ! com
[Download RAW message or body]

On Mon, 30 Aug 2021 02:22:14 -0700, Tejas Upadhyay wrote:
>
>  bool gem_has_mmap_offset_type(int fd, const struct mmap_offset *t)
>  {
> -	return gem_has_mmap_offset(fd) || t->type == I915_MMAP_OFFSET_GTT;
> +	if (gem_has_mmap_offset(fd))
> +		if (gem_has_lmem(fd))
> +			return t->type == I915_MMAP_OFFSET_FIXED;
> +		else
> +			return t->type != I915_MMAP_OFFSET_FIXED;

The above looks correct to me.

> +	else
> +		return false;

But about this, from the previous logic, shouldn't this be:

		return t->type == I915_MMAP_OFFSET_GTT;
[prev in list] [next in list] [prev in thread] [next in thread]