[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-igt-dev
Subject:    Re: [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: Skip on platforms without atomic modesetting
From:       Matt Roper <matthew.d.roper () intel ! com>
Date:       2019-08-30 15:58:07
Message-ID: 20190830155807.GX13677 () mdroper-desk ! amr ! corp ! intel ! com
[Download RAW message or body]

On Fri, Aug 30, 2019 at 12:27:45AM -0700, Ser, Simon wrote:
> On Thu, 2019-08-29 at 09:47 -0700, Matt Roper wrote:
> > This test performs display updates via COMMIT_ATOMIC, but fails to check
> > that the platform being tested actually supports atomic.  This causes
> > failures on some of our older pre-gen5 platforms.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106012
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> 
> Reviewed-by: Simon Ser <simon.ser@intel.com>

Pushed, thanks for the review.


Matt

> 
> > ---
> >  tests/kms_rotation_crc.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> > index fe404810..668c1732 100644
> > --- a/tests/kms_rotation_crc.c
> > +++ b/tests/kms_rotation_crc.c
> > @@ -780,6 +780,7 @@ igt_main
> >  		igt_require_pipe_crc(data.gfx_fd);
> >  
> >  		igt_display_require(&data.display, data.gfx_fd);
> > +		igt_require(data.display.is_atomic);
> >  	}
> >  
> >  	for (subtest = subtests; subtest->rot; subtest++) {

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
[prev in list] [next in list] [prev in thread] [next in thread]