[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-fribidi
Subject:    Re: [FriBidi] FriBracketType
From:       Dov Grobgeld <dov.grobgeld () gmail ! com>
Date:       2017-11-14 17:07:04
Message-ID: CA++fsGG0gJ8HuqmgMNS7kmRihoZAbseYkjQw71fdqMJn_WAKsg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Fixed in commit:0e273c1. (And of course in my previous mail I meant
0x7ffffff...)

Regards,
Dov

On Tue, Nov 14, 2017 at 1:31 PM, Dov Grobgeld <dov.grobgeld@gmail.com>
wrote:

> No reason, except if bracket_id would be greater than 0x3fffffff, which is
> not very likely. I'll change it before the release.
>
> Dov
>
>
> On Tue, Nov 14, 2017 at 4:10 AM, Behdad Esfahbod <behdad@behdad.org>
> wrote:
>
>> Any reason the bracket-type cannot be a single FriBidiChar, with the top
>> bit used to indication open/close?  It's wasteful the way it is right now:
>>
>> struct _FriBracketTypeStruct {
>>   FriBidiChar bracket_id;
>>   fribidi_boolean is_open;
>> };
>>
>> --
>> behdad
>> http://behdad.org/
>>
>
>

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif">Fixed in commit:0e273c1. (And of \
course in my previous mail I meant 0x7ffffff...)</div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif">Regards,</div><div \
class="gmail_default" \
style="font-family:arial,helvetica,sans-serif">Dov<br></div></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 14, 2017 at 1:31 PM, Dov \
Grobgeld <span dir="ltr">&lt;<a href="mailto:dov.grobgeld@gmail.com" \
target="_blank">dov.grobgeld@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif">No reason, except if bracket_id would \
be greater than 0x3fffffff, which is not very likely. I&#39;ll change it before the \
release.</div><span class="HOEnZb"><font color="#888888"><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif">Dov</div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif"><br></div></font></span></div><div \
class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div \
class="gmail_quote">On Tue, Nov 14, 2017 at 4:10 AM, Behdad Esfahbod <span \
dir="ltr">&lt;<a href="mailto:behdad@behdad.org" \
target="_blank">behdad@behdad.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">Any reason the bracket-type cannot be a single \
FriBidiChar, with the top bit used to indication open/close?   It&#39;s wasteful the \
way it is right now:<br><br>struct _FriBracketTypeStruct { <br>   FriBidiChar \
bracket_id; <br>   fribidi_boolean is_open; <br>}; <br><span \
class="m_499572464746171438HOEnZb"><font color="#888888"><div><br>-- <br><div \
class="m_499572464746171438m_-315054422434703915gmail_signature">behdad<br><a \
href="http://behdad.org/" target="_blank">http://behdad.org/</a></div> \
</div></font></span></div> </blockquote></div><br></div>
</div></div></blockquote></div><br></div>


[Attachment #6 (text/plain)]

_______________________________________________
fribidi mailing list
fribidi@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/fribidi


[prev in list] [next in list] [prev in thread] [next in thread]