[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-dbus
Subject:    Re: Proper handling of the dbus call method timeout
From:       Thiago Macieira <thiago () kde ! org>
Date:       2023-06-09 0:10:12
Message-ID: 3204913.AJdgDx1Vlc () tjmaciei-mobl5
[Download RAW message or body]

On Thursday, 8 June 2023 06:04:55 PDT Simon McVittie wrote:
> * changing what happens when the maximum number of pending replies is
>   reached, so that instead of making the *newest* calls from the same
>   client fail, the dbus-daemon would make the *oldest* calls for the same
>   client (or maybe the same (client,service) pair) report a NoReply or
>   LimitsExceeded failure message synthesized by the dbus-daemon

I don't think that's completely right. There may be many reasons why replies 
to newer messages are sent before older ones, so attempting to add this code, 
even if it kicks in only for when the maximum number of replies is reached, is 
potentially a source of bugs.

The bug should be fixed where the bug is: in the daemon in question.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel DCAI Cloud Engineering



[prev in list] [next in list] [prev in thread] [next in thread]