[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-dbus
Subject:    Re: cygwin dbus port patches
From:       Thiago Macieira <thiago () kde ! org>
Date:       2010-06-17 16:35:23
Message-ID: 201006171835.23657.thiago () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Em Quinta-feira 17 Junho 2010, Ã s 10:34:05, Ralf Habacker escreveu:
> Thiago Macieira schrieb:
> > Em Segunda-feira 14. Junho 2010, Ã s 04.15.34, Yaakov (Cygwin/X) escreveu:
> >> On Sun, 2010-06-13 at 20:38 +0200, Thiago Macieira wrote:
> >>>> There are some flags which GCC allows but have no effect on Cygwin and
> >>>> therefore generate warnings as such.  This includes -fPIC and
> >>>> -fvisibility*.  Adding the -Werror to cc_supports_flag makes sure that
> >>>> the flag is truly supported and necessary.
> >>> 
> >>> The problem is that this will cause false-negatives when building code
> >>> that is valid.
> >>> 
> >>> I've seen this before, that in maintainer mode there are a couple of
> >>> extra warnings enabled like the prototype warning.
> >> 
> >> My patch doesn't add -Werror to CFLAGS, it just adds it to
> >> cc_supports_flag's testing of the flag itself.  So this will not cause
> >> any problems with the code itself.
> > 
> > It causes false-positives in cc_supports_flag because testing the option
> > causes a warning because of the source code.
> 
> Do we have a solution for this ?

I'd rather keep the warnings than risk false positives.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

["signature.asc" (application/pgp-signature)]

_______________________________________________
dbus mailing list
dbus@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dbus


[prev in list] [next in list] [prev in thread] [next in thread]