[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-dbus
Subject:    Re: [patch] Make dbus-launch always (if possible) save
From:       Thiago Macieira <thiago () kde ! org>
Date:       2007-11-23 10:04:05
Message-ID: 200711231104.11900.thiago () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Em Tuesday 20 November 2007 07:49:37 Thiago Macieira escreveu:
> >- are you sure we didn't do this autolaunch-only on purpose?
> >     it doesn't seem like we'd have done this accidentally.
> >     it might be worth going through the archived discussion.
> >- it would be good if Thiago could review this before commit
> >- this code (before you touched it also) is very, very confusing to me
> >     for some reason - not sure if it's all the many dbus-launch modes or
> >     what... ;-)
>
> I will review it later today.

Where "today" is a few days later.

Sorry about that.

Patch looks ok to me. I think it addresses the most common use-cases.

I'd also argue for replacing the non-default --autolaunch with a 
non-default --no-reuse. That way, the default behaviour would be to reuse a 
bus if one is running. Those special cases that require a new bus would use 
the flag to do it.

-- 
   Thiago Macieira   -   thiago (AT) macieira.info - thiago (AT) kde.org
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C   966C 33F5 F005 6EF4 5358

["signature.asc" (application/pgp-signature)]

_______________________________________________
dbus mailing list
dbus@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dbus


[prev in list] [next in list] [prev in thread] [next in thread]