[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-dbus
Subject:    Re: [patch] fix for return value bug in dbus_message_iter_init
From:       Havoc Pennington <hp () redhat ! com>
Date:       2005-01-24 19:51:24
Message-ID: 1106596284.13493.109.camel () localhost ! localdomain
[Download RAW message or body]

On Mon, 2005-01-24 at 13:33 -0500, Joe Shaw wrote:
> Hi,
> 
> There's a bug in the new type stuff where if you call
> dbus_message_iter_init() on a message with only one argument, it'll
> return FALSE, meaning that there are no arguments.  I think this is
> because the code is moving the reader past the first argument and then
> calling _dbus_type_reader_get_current_type(), but I don't have a great
> grasp on this new type code...
> 
> There's also a minor string change to improve the error message when a
> method doesn't exist.  Havoc, can you take a look at it and see if it's
> sane?
> 

Both changes look good, thanks.

Havoc



[prev in list] [next in list] [prev in thread] [next in thread]