[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-wireless
Subject:    patch proposal for marvell driver
From:       adrian () freebsd ! org (Adrian Chadd)
Date:       2011-12-30 19:55:20
Message-ID: CAJ-VmomOE07qjpez6DFaDUBSkRR8QwUe05HYFyJ-=t1FA14pQg () mail ! gmail ! com
[Download RAW message or body]

On 30 December 2011 10:10, Philippe Saint-Pierre <stpere@gmail.com> wrote:
> Hi,
>
> I'm sending this small patch for the marvell wifi driver.
>
> Basically, in mwl_hal_bastream_alloc(), there is a sp = ... assignment that
> could return NULL, then several derefencing of sp then finally, a NULL
> check on sp before returning.
>
> I simply moved the NULL check before the dereferences tries occurs.

Thanks for noticing this! I haven't yet tried any of the mwl cards Sam gave me.
Would you mind throwing this into a PR?

Thanks,


Adrian

[prev in list] [next in list] [prev in thread] [next in thread]