[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-ports-bugs
Subject:    ports/53939: [PATCH] Fix library dependencies in samba-devel port
From:       Scott Mitchell <scott+freebsd () fishballoon ! org>
Date:       2003-06-30 21:51:03
[Download RAW message or body]


> Number:         53939
> Category:       ports
> Synopsis:       [PATCH] Fix library dependencies in samba-devel port
> Confidential:   no
> Severity:       non-critical
> Priority:       medium
> Responsible:    freebsd-ports-bugs
> State:          open
> Quarter:        
> Keywords:       
> Date-Required:
> Class:          sw-bug
> Submitter-Id:   current-users
> Arrival-Date:   Mon Jun 30 15:00:19 PDT 2003
> Closed-Date:
> Last-Modified:
> Originator:     Scott Mitchell
> Release:        FreeBSD 4.8-STABLE i386
> Organization:
> Environment:
System: FreeBSD tuatara 4.8-STABLE FreeBSD 4.8-STABLE #0: Sun Apr 13 14:23:25 BST \
2003 scott@tuatara:/local/0/obj/usr/src/sys/TUATARA i386

> Description:
The net/samba-devel port has a WITHOUT_CUPS Makefile option that drops the
*port's* dependency on the CUPS library, but does not actually pass the option
to configure to build Samba without CUPS support.  The resulting binaries will
still have a runtime dependency on the CUPS library.

Similarly, the binaries built by the port have a runtime dependency on the
popt (port devel/popt) library which is not listed in the Makefile.

> How-To-Repeat:

	# cd /usr/ports/net/samba-devel
	# make -DWITHOUT_CUPS package

Then install the resulting package on a machine that does not have CUPS and/or
popt installed.  The package will install without complaint but smdb, nmdb,
etc. will not run due to the unsatisfied runtime library dependencies.

> Fix:
The attached patch:
1. Passes the --enable-cups=no option to configure when WITHOUT_CUPS is
   specified.
2. Adds a new WITHOUT_POPT Makefile option.  If this is specified, the
   --with-included-popt option is passed to configure, to build Samba using
   its internal popt implementation rather than the port.  If WITHOUT_POPT is
   not specified, the popt library from devel/popt is added to LIB_DEPENDS.

Index: ports/net/samba-devel/Makefile
===================================================================
RCS file: /home/ncvs/ports/net/samba-devel/Makefile,v
retrieving revision 1.91
diff -u -r1.91 Makefile
--- ports/net/samba-devel/Makefile	24 Mar 2003 19:02:34 -0000	1.91
+++ ports/net/samba-devel/Makefile	30 Jun 2003 21:35:51 -0000
@@ -50,6 +50,10 @@
 
 .include <bsd.port.pre.mk>
 
+.if defined(WITHOUT_CUPS)
+CONFIGURE_ARGS+=	--enable-cups=no
+.endif
+
 .if defined(WITH_QUOTAS)
 CONFIGURE_ARGS+=	--with-quotas
 .endif
@@ -87,6 +91,12 @@
 .if defined(WITH_LIBICONV)
 LIB_DEPENDS+=		iconv.3:${PORTSDIR}/converters/libiconv
 CONFIGURE_ARGS+=	--with-libiconv
+.endif
+
+.if defined(WITHOUT_POPT)
+CONFIGURE_ARGS+=	--with-included-popt
+.else
+LIB_DEPENDS+=		popt.0:${PORTSDIR}/devel/popt
 .endif
 
 WRKSRC=		${WRKDIR}/${DISTNAME}/source
> Release-Note:
> Audit-Trail:
> Unformatted:


[prev in list] [next in list] [prev in thread] [next in thread]