[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-ports
Subject:    Re: FreeBSD Port: ports-mgmt/poudriere
From:       Bryan Drewery <bdrewery () FreeBSD ! org>
Date:       2016-08-29 23:29:40
Message-ID: fb4b61e4-bf96-b7b0-ec53-d9232ddb6a9d () FreeBSD ! org
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On 8/29/2016 4:27 PM, Don Lewis wrote:
> On 30 Aug, Miroslav Lachman wrote:
>> Hi,
>>
>> I would like to report one "dangerous" problem with "poudriere ports -d" 
>> command. There should be a "-p treename" but if it is omitted, poudriere 
>> deletes tree "default"
>>
>> This is my error, I know, but I think poudrier should print a warning or 
>> do not assume I wanted delete "default"
>>
>> root@sm-reserve ~/# poudriere ports -d headtest

I did add a confirmation into jail -d.  I will extend it to ports -d as
well.

>> [00:00:00] ====>> Deleting portstree "default" done
>>
>> It should be
>>
>> root@sm-reserve ~/# poudriere ports -d -p headtest
>> [00:00:00] ====>> Deleting portstree "headtest" done
> 
> Yeah, that bit me too.  The poudriere man page even says:
> 
>      Except for -l, all of the subcommands require the -p switch (see
>      below).
> 
> Even worse in my case, it deleted a ports tree that was not even created
> by poudriere.  My default ports tree is actually /usr/ports and I hooked
> it into poudrire by doing something like:
> 	poudriere ports -c -p default -F -M /usr/ports
> 

This is a separate bug.

> IMHO, if the ports tree was not created by poudriere, then -k should be
> the default when deleting it.
> 


-- 
Regards,
Bryan Drewery


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]