[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-pf
Subject:    [Differential] D1944: PF and VIMAGE fixes
From:       "kristof (Kristof Provost)" <phabric-noreply () FreeBSD ! org>
Date:       2016-04-24 11:33:20
Message-ID: f8b065a00d567124c7f250a9b69c9f39 () localhost ! localdomain
[Download RAW message or body]

kristof added inline comments.

INLINE COMMENTS
  sys/netpfil/pf/pf_if.c:130 I don't understand why this is required. Surely if an \
ifnet lives in V_ifnet (so, lives in the current vnet) ifp->if_vnet is always going \
to be curvnet?  sys/netpfil/pf/pf_if.c:141 Why add curvnet here?
  pfi_attach_ifnet_event doesn't use its argument.
  sys/netpfil/pf/pf_if.c:143 Same as above.
  sys/netpfil/pf/pf_if.c:151 Same as above.
  sys/netpfil/pf/pf_if.c:814 I believe this is correct, but should probably include \
adding an __unused annotation to arg, and removing the 'curvnet' argument from the \
EVENTHANDLER_REGISTER() call.

REVISION DETAIL
  https://reviews.freebsd.org/D1944

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri
Cc: ryan_timewasted.me, mmoll, javier_ovi_yahoo.com, farrokhi, julian, robak, \
freebsd-virtualization-list, freebsd-pf-list, freebsd-net-list \
_______________________________________________ freebsd-pf@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "freebsd-pf-unsubscribe@freebsd.org"


[prev in list] [next in list] [prev in thread] [next in thread]