[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-net
Subject:    [Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgra
From:       "wblock (Warren Block)" <phabric-noreply () FreeBSD ! org>
Date:       2017-03-24 16:03:23
Message-ID: 42b65bf02038bbb05e8e8f008d47dcf8 () localhost ! localdomain
[Download RAW message or body]

wblock accepted this revision.
wblock added a comment.
This revision has a positive review.


  One suggestion, but looks good otherwise.  Thank you!

INLINE COMMENTS

> ng_pppoe.4:115
> +.Qq Li 0x ,
> +eg. 
> +.Qq Li 0x6d792d746167

Would prefer "like" or "for example" to exempli gratia here (see `igor -y \
ng_pppoe.4`), but if you want to stick with that, it should be "e.g.,".  Yes, it's \
clunky.  In this case, I prefer "like".

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D9270

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: ale, julian, #manpages, mav, #network, adrian, wblock
Cc: wblock, mav, poolroom_gmail.com, mandree, imp, freebsd-net-list
_______________________________________________
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"


[prev in list] [next in list] [prev in thread] [next in thread]