[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-net
Subject:    Re: switching to if_xname from if_name and if_unit
From:       Brooks Davis <brooks () one-eyed-alien ! net>
Date:       2002-07-30 18:30:44
[Download RAW message or body]

On Wed, Jul 31, 2002 at 04:22:23AM +1000, Bruce Evans wrote:
> On Tue, 30 Jul 2002, Brooks Davis wrote:
> 
> > On Mon, Jul 29, 2002 at 10:38:34PM -0600, M. Warner Losh wrote:
> > > : @@ -280,8 +280,7 @@ ep_attach(sc)
> > > :         attached = (ifp->if_softc != 0);
> > > :
> > > :         ifp->if_softc = sc;
> > > : -       ifp->if_unit = sc->unit;
> > > : -       ifp->if_name = "ep";
> > > : +       sprintf(ifp->if_xname, "ep%d", sc->unit);
> > >
> > > 	strcpy(ifp->if_xname, device_get_name(sc->dev));
> > >
> > > might be better, don't you think?
> 
> I think this point has already been covered better by noticing that the
> name is already stored in several other places (not just new-bus).

I don't think it's stored elsewhere for pure pseudo interfaces like lo
or gif though (except as "if_<name>" in the module decleration.)  I
don't see name that is consistantly associated with all interfaces.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

[Attachment #3 (application/pgp-signature)]
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message

[prev in list] [next in list] [prev in thread] [next in thread]