[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-hackers
Subject:    Re: bug in latests NFS patches for -stable
From:       Matthew Dillon <dillon () apollo ! backplane ! com>
Date:       1999-06-30 4:22:49
[Download RAW message or body]

    Hey guys.  Sorry, I've been busy messing with Kirk's locking code.

    Yes, David found a critical bug all right!  When I changed the return(0);
    that had previously been in this section of code to a 'goto nfsmout',
    I forgot to set error = 0.

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>


:Matt, 
:If you agree with this patch to your patch
:I'll commit the NFS fixes to 3.x
:(I'll also add this change to the 4.0 version.)
:
:*** hold/nfs_serv.c	Tue Jun 22 13:37:17 1999
:--- nfs_serv.c	Tue Jun 29 20:42:44 1999
:***************
:*** 1580,1585 ****
:--- 1580,1586 ----
:  	if (error) {
:  		nfsm_reply(NFSX_WCCDATA(v3));
:  		nfsm_srvwcc_data(dirfor_ret, &dirfor, diraft_ret, &diraft);
:+ 		error=0;
:  		goto nfsmout;
:  	}
:  
:> 
:> http://www.cs.rpi.edu/~crossd/FreeBSD/nfspatch3a.diff
:
:see above for diff
:  ... Julian
:
:> David Cross                               | email: crossd@cs.rpi.edu 



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message

[prev in list] [next in list] [prev in thread] [next in thread]