[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-hackers
Subject:    Re: WHy does Appache eat my system?
From:       Luigi Rizzo <luigi () labinfo ! iet ! unipi ! it>
Date:       1997-05-31 20:44:21
[Download RAW message or body]

> > Secondly, the identifier used in tsleep/wakeup is actually hashed
> > and collisions might occur. Since the hash table is relatively
> > small (128 entries) collisions are not that unlikely.
> 
> This is an error.  The usage of the tsleep() family of functions
> requires that a unique sleep address be treated uniquely.  I think
> maybe you are misreading the code.

you are very right, I did not see a test "if (p->p_wchan == ident) {"
in wakeup().

> SVR4 implements a "wakeone" function in addition to "wakeup".  For
> the reasons noted in my other post, this is not an optimal soloution.

There appears to be a wakeup_one() function in the same file as
wakeup(), but it is never used (or so it seems, after grepping the
source tree).

	Cheers
	Luigi

[prev in list] [next in list] [prev in thread] [next in thread]