[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-hackers
Subject:    Re: rlogind user name restrictions
From:       Guido van Rooij <guido () gvr ! win ! tue ! nl>
Date:       1996-10-30 20:39:59
[Download RAW message or body]

john@starfire.mn.org wrote:
> 
> > --- /usr/src/libexec/rlogind/rlogind.c	Sun Jun 23 15:07:44 1996
> > +++ /tmp/rlogind.c	Wed Oct 30 20:55:23 1996
> > @@ -293,7 +293,7 @@
> >  		if (f > 2)	/* f should always be 0, but... */
> >  			(void) close(f);
> >  		setup_term(0);
> > -		if (strchr(lusername, '-')) {
> > +		if (lusername == '-') {
>                     ^^^^^^^^^
> Shouldn't this be "*lusername" or "lusername[0]"?????????
Of course that should be *lusername.
That's the problem when you havent setup cvsup and you do things by
head ;-()

> 
> Even doing this, has it been checked that there are no throw-away
> characters that login might skip over that would make the corrected
> test ineffectual?  I'm not that totally familiar with the internal
> operation of "getopt" that I could speak authoritatively to this
> issue, which is why I didn't submit my diffs in the first place.
> That was what I meant by "BAD THINGS".

no problems there.

-Guido

[prev in list] [next in list] [prev in thread] [next in thread]