[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-hackers
Subject:    Re: correct ways to get code reviewed
From:       Brooks Davis <brooks () freebsd ! org>
Date:       2019-09-13 14:05:43
Message-ID: 20190913140543.GC93439 () spindle ! one-eyed-alien ! net
[Download RAW message or body]


On Fri, Sep 13, 2019 at 11:49:23AM +0530, Mihir Luthra wrote:
> Hi everyone,
> 
> I am a new contributor to FreeBSD projects. Recently I have started making
> changes in the source code by working on project ipv6 userland cleanup [1].
> I did post one patch to phabrictor which got reviewed as well.
> 
> I had some queries in my mind on which I wanted some advice.
> 1) Should I post another patch only after the first one has been approved
> or is it better to keep posting patches irrespective of review status of
> the first?

It's fine to post multiple patches.  If you have multiple patches that
depend on each other you may find it useful to post both to let reviewers
see the bigger picture.

> 2) Should I ask commiters for review individually or should I post the link
> on the mailing lists? Or maybe should I simply wait for the patch to get
> reviewed without informing anyone?

Asking individual committers is a good approach if you can identify an
active committers in the area.  Mailing lists can also work.  I don't
recommend posting patching and hoping someone reviews them.  That's all too
likely to result in them being dropped.

> 3) If the patch gets approved, do I need to submit a pul request on github
> or is their some different procedure?

If a patch is approved, you should ask the reviewer(s) to commit it.  Can
easily use "arc patch" to apply it and commit it.

-- Brooks

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]