[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-hackers
Subject:    Re: Parsing a comment in stdlib.h
From:       "Rodney W. Grimes" <freebsd-rwg () pdx ! rh ! CN85 ! dnsmgr ! net>
Date:       2017-12-27 18:01:48
Message-ID: 201712271801.vBRI1maU061954 () pdx ! rh ! CN85 ! dnsmgr ! net
[Download RAW message or body]

> I would say that your proposed change makes it less clear.  For one thing,
> it's not clear whether those three bullet points are meant to be ANDed or
> ORed.  For another, I'm not sure why you removed the part about "long
> long".  Finally, s/its/it's/.  Frankly, I think the comment can just be

s/it's/it is/  Contractons should not be used in manual pages.

> shortened to "C99 functions".  GCC and Clang both support "long long".  Are
> there any external compilers that don't?

And I agree, that this change is less clear than the already unclear
text that is there.  

> 
> On Tue, Dec 26, 2017 at 8:18 PM, Eitan Adler <lists@eitanadler.com> wrote:
> 
> > Hi all,
> >
> > I'm trying to understand a visibility comment in stdlib.h. Is the
> > following change technically correct?
> > Can it be made more clear?
> >
> > Index: include/stdlib.h
> > ===================================================================
> > --- include/stdlib.h (revision 327228)
> > +++ include/stdlib.h (working copy)
> > @@ -120,8 +120,10 @@ int wctomb(char *, wchar_t);
> >  size_t wcstombs(char * __restrict, const wchar_t * __restrict, size_t);
> >
> >  /*
> > - * Functions added in C99 which we make conditionally available in the
> > - * BSD^C89 namespace if the compiler supports `long long'.
> > + * Functions added in C99 which we make available if
> > + * - its C99
> > + * - BSD visible and not C89
> > + * - its C++
> >   * The #if test is more complicated than it ought to be because
> >   * __BSD_VISIBLE implies __ISO_C_VISIBLE == 1999 *even if* `long long'
> >   * is not supported in the compilation environment (which therefore means
> >
> >
> > --
> > Eitan Adler
> > _______________________________________________
> > freebsd-hackers@freebsd.org mailing list
> > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
> >
> _______________________________________________
> freebsd-hackers@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org
_______________________________________________
freebsd-hackers@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
[prev in list] [next in list] [prev in thread] [next in thread]