[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-hackers
Subject:    Re: Fixing grep -D skip
From:       Xin Li <delphij () delphij ! net>
Date:       2013-01-19 0:15:53
Message-ID: 50F9E5B9.1050402 () delphij ! net
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 01/18/13 08:39, John Baldwin wrote:
> On Thursday, January 17, 2013 9:33:53 pm David Xu wrote:
>> I am trying to fix a bug in GNU grep, the bug is if you want to 
>> skip FIFO file, it will not work, for example:
>> 
>> grep -D skip aaa .
>> 
>> it will be stucked on a FIFO file.
>> 
>> Here is the patch: 
>> http://people.freebsd.org/~davidxu/patch/grep.c.diff2
>> 
>> Is it fine to be committed ?
> 
> I think the first part definitely looks fine.  My guess is the 
> non-blocking change is als probably fine, but that should be run
> by the bsdgrep person at least.

I (disclaimer: not bsdgrep person) have just tested that bsdgrep
handle this case just fine.

The non-blocking part is required to make the code function, otherwise
the system will block on open() if fifo don't have another opener.
I'd say "Yes" for this p

Cheers,
- -- 
Xin LI <delphij@delphij.net>    https://www.delphij.net/
FreeBSD - The Power to Serve!           Live free or die
a
-----BEGIN PGP SIGNATURE-----

iQEcBAEBCgAGBQJQ+eW5AAoJEG80Jeu8UPuzaPkH/RPnvBg5pDPxmbSXWF3T22s3
XTPNfDns416g6dqig+E+YOhamu+Pz8xFC6JCu3DzPbNcb+OGRh14LBFeZQ6xn648
yxn1j0Y2ZsmjoppMAWg+wuwLtOYX0pK69zZzOxQMepBeA/rkA26hJA/3j6VTPu/X
hLFP+bRy+wt8Ni39PuSrBywuPmwg82de+Fuf8WVVVwXgXHnK+yc/Pb1JWgiU6kzz
r1tyCAh2rXcM4mg++LUoeYZZhrLuxWKKPrXkzGSbz7NSPXJccwf5rx/ZPB2EysVv
Z/CA6wS2jqsOUbyelM01jtvrY6Q6llLIIEc3aGPcjYZbqy/B0VLwyGnR+rElKBo=
=M7oI
-----END PGP SIGNATURE-----
_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
[prev in list] [next in list] [prev in thread] [next in thread]